Skip to content
This repository has been archived by the owner. It is now read-only.

8252798: Cleanup LCD text rendering code #89

Closed
wants to merge 1 commit into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Sep 7, 2020

There is lot of unused code and constructs in LCD text rendering. This is a cleanup task.


Progress

  • Change must not contain extraneous whitespace

Issue

Download

$ git fetch https://git.openjdk.java.net/lanai pull/89/head:pull/89
$ git checkout pull/89

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@jayathirthrao This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252798: Cleanup LCD text rendering code
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate db306e2f0938b67d07cc79a074fc578effea2e88.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 7, 2020
@jayathirthrao
Copy link
Member Author

jayathirthrao commented Sep 7, 2020

/integrate

@openjdk openjdk bot closed this Sep 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@jayathirthrao Pushed as commit ab213f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8252798 branch Sep 7, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
1 participant