Skip to content
This repository has been archived by the owner. It is now read-only.

8252949: Shape clip should use identity transform for drawing clip spans #91

Closed
wants to merge 1 commit into from

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Sep 9, 2020

Issue : https://bugs.openjdk.java.net/browse/JDK-8252949
Fix : Metal does not have glPushMatrix and glPopMatrix equivalent APIs. Hence, the transformation matrix is saved and restored using a temporary MTLTransform object for shape clip drawing.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8252949: Shape clip should use identity transform for drawing clip spans

Download

$ git fetch https://git.openjdk.java.net/lanai pull/91/head:pull/91
$ git checkout pull/91

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 9, 2020

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2020

@aghaisas This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252949: Shape clip should use identity transform for drawing clip spans
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 2c50c0f4fb282072508dd4943a693917ec8dcedc.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented Sep 9, 2020

/integrate

@openjdk openjdk bot closed this Sep 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2020

@aghaisas Pushed as commit 6cecbed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 9, 2020

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant