Skip to content
This repository has been archived by the owner. It is now read-only.

8252795: Lanai: Refactor native implementation of MTLPaint #98

Closed
wants to merge 1 commit into from

Conversation

@avu
Copy link
Collaborator

@avu avu commented Sep 15, 2020

Created base class MTLPaint responsible only for blit rendering
Added MTLColorPaint, MTLGradPaint, ... classes representing particular paint modes


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8252795: Lanai: Refactor native implementation of MTLPaint

Download

$ git fetch https://git.openjdk.java.net/lanai pull/98/head:pull/98
$ git checkout pull/98

Created base class MTLPaint responsible only for blit rendering
Added MTLColorPaint, MTLGradPaint, ... classes representing particular paint modes
@avu
Copy link
Collaborator Author

@avu avu commented Sep 15, 2020

/integrate

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

👋 Welcome back avu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@avu This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252795: Lanai: Refactor native implementation of MTLPaint
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 6 commits pushed to the master branch:

  • d638a78: Automatic merge of jdk:master into master
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • aa75d33: Automatic merge of jdk:master into master
  • 4020682: 8172366: Support SHA-3 based signatures
  • 06db9a2: Automatic merge of jdk:master into master
  • 46598c8: 8253177: outputStream not declared in markWord.hpp

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d638a78e9149fb431ae89ceb8c5f8072103816a1.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@avu
Copy link
Collaborator Author

@avu avu commented Sep 15, 2020

/integrate

@openjdk openjdk bot closed this Sep 15, 2020
@openjdk openjdk bot added integrated and removed ready labels Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@avu Since your change was applied there have been 6 commits pushed to the master branch:

  • d638a78: Automatic merge of jdk:master into master
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • aa75d33: Automatic merge of jdk:master into master
  • 4020682: 8172366: Support SHA-3 based signatures
  • 06db9a2: Automatic merge of jdk:master into master
  • 46598c8: 8253177: outputStream not declared in markWord.hpp

Your commit was automatically rebased without conflicts.

Pushed as commit 243c841.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

@avu avu deleted the JDK-8252795 branch Dec 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2020

@avu The command integrate can only be used in open pull requests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant