-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317452: [JVMCI] Export symbols used by lightweight locking to JVMCI compilers. #74
Conversation
…compilers. Reviewed-by: dnsimon
👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into |
@rkennke This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable.
@@ -4069,9 +4069,6 @@ jint Arguments::apply_ergo() { | |||
#ifdef COMPILER1 | |||
|| !UseFastLocking | |||
#endif // COMPILER1 | |||
#if INCLUDE_JVMCI | |||
|| !JVMCIUseFastLocking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit concerned this subtly changes the observable VM behavior by JVMCI compilers, but it looks like the flag is already develop
, and so cannot really affect release binaries.
Thanks! /integrate |
Going to push as commit 46c75ee. |
Backport of openjdk/jdk@9718f49
Eases subsequent backports and makes JVMCI compatible with future Graal LW locking impl.
Unclean because of context diff in vmStructs_jvmci.cpp, otherwise straightforward.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/74/head:pull/74
$ git checkout pull/74
Update a local copy of the PR:
$ git checkout pull/74
$ git pull https://git.openjdk.org/lilliput-jdk17u.git pull/74/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 74
View PR using the GUI difftool:
$ git pr show -t 74
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/lilliput-jdk17u/pull/74.diff
Webrev
Link to Webrev Comment