Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317452: [JVMCI] Export symbols used by lightweight locking to JVMCI compilers. #18

Closed
wants to merge 1 commit into from

Conversation

rkennke
Copy link
Collaborator

@rkennke rkennke commented Mar 25, 2024

Hi all,

This pull request contains a backport of commit 9718f490 from the openjdk/jdk repository.

The commit being backported was authored by Yudi Zheng on 4 Oct 2023 and was reviewed by Doug Simon.

The original change has not applied cleanly due to minor context changes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317452: [JVMCI] Export symbols used by lightweight locking to JVMCI compilers. (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/lilliput-jdk21u.git pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/lilliput-jdk21u/pull/18.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2024

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into lilliput will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317452: [JVMCI] Export symbols used by lightweight locking to JVMCI compilers.

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lilliput branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lilliput branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9718f490fb76f6712ac8f9c7f5248ca10bf83e6f 8317452: [JVMCI] Export symbols used by lightweight locking to JVMCI compilers. Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2024

Webrevs

@rkennke
Copy link
Collaborator Author

rkennke commented Mar 25, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit 6799201.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@rkennke Pushed as commit 6799201.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants