Skip to content

8310513: [s390x] Intrinsify recursive ObjectMonitor locking #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Jun 28, 2024

Hi all,

This pull request contains a backport of commit 47df1459 from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 10 Apr 2024 and was reviewed by Lutz Schmidt and Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8310513: [s390x] Intrinsify recursive ObjectMonitor locking (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/33/head:pull/33
$ git checkout pull/33

Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.org/lilliput-jdk21u.git pull/33/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33

View PR using the GUI difftool:
$ git pr show -t 33

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/lilliput-jdk21u/pull/33.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into lilliput will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 47df14590c003ccb1607ec0edfe999fcf2aebd86 8310513: [s390x] Intrinsify recursive ObjectMonitor locking Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 28, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2024

Webrevs

@offamitkumar
Copy link
Member Author

Almost clean backport, I got conflicts in copyright headers only.

@rkennke
Copy link
Collaborator

rkennke commented Jun 28, 2024

I don't think that this change is Lilliput-specific. It looks like you already backported it to 21u, from where it will get picked-up to lilliput-jdk21u the next time we merge from upstream (which is overdue). Also I don't think Lilliput currently works on
s390.

@offamitkumar
Copy link
Member Author

It looks like you already backported it to 21u, from where it will get picked-up to lilliput-jdk21u the next time we merge from upstream (which is overdue).

Thanks for info :)

I'll close it now.

@offamitkumar offamitkumar deleted the backport-offamitkumar-47df1459-lilliput branch June 28, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants