Skip to content

8314545: [Lilliput] Revert changes in zRelocate.cpp #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rkennke
Copy link
Collaborator

@rkennke rkennke commented Aug 17, 2023

We have a bunch of STS additions in zRelocate.cpp . The guidance that I've got from @fisk is that those are not needed and may in-fact cause deadlocks. Let's remove those changes and figure out if anything else is needed to deal with ZGC sync with ObjectMonitor deflation.

Testing:

  • hotspot_gc +UCOH
  • tier1 +UCOH

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8314545: [Lilliput] Revert changes in zRelocate.cpp (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/lilliput.git pull/105/head:pull/105
$ git checkout pull/105

Update a local copy of the PR:
$ git checkout pull/105
$ git pull https://git.openjdk.org/lilliput.git pull/105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 105

View PR using the GUI difftool:
$ git pr show -t 105

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/lilliput/pull/105.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 17, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2023

Webrevs

@rkennke
Copy link
Collaborator Author

rkennke commented Aug 17, 2023

Awww, this results in the following crash. This is exactly the symptom of missing sync between ZGC worker and monitor deflation. Moving this PR back to draft until we figured something out.

A fatal error has been detected by the Java Runtime Environment:

Internal Error (/home/rkennke/src/openjdk/lilliput/src/hotspot/share/oops/markWord.inline.hpp:39), pid=19182, tid=19184

assert(!CompressedKlassPointers::is_null(narrow_klass())) failed: narrow klass must not be null: 0x0000000000000001

JRE version: OpenJDK Runtime Environment (22.0) (fastdebug build 22-internal-adhoc.rkennke.lilliput)

Java VM: OpenJDK 64-Bit Server VM (fastdebug 22-internal-adhoc.rkennke.lilliput, mixed mode, tiered, compressed class ptrs, z gc, linux-amd64)

Problematic frame:

V [libjvm.so+0x2f6d4f] markWord::klass() const [clone .part.36]+0x21

No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again

An error report file with more information is saved as:

/local/home/rkennke/src/openjdk/lilliput/build/linux-x86_64-server-fastdebug/test-support/jtreg_test_hotspot_jtreg_hotspot_gc/scratch/15/hs_err_pid19182.log

If you would like to submit a bug report, please visit:

https://bugreport.java.com/bugreport/crash.jsp

@rkennke rkennke marked this pull request as draft August 17, 2023 21:19
@openjdk openjdk bot removed the rfr Pull request is ready for review label Aug 17, 2023
@rkennke rkennke closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant