8326753 Lilliput: OMCache: Use AoS

[xmas92]

The OMCache entries are currently laid out as a struct of arrays. For cache locality layout the entries as an array of structs.

Using structs for the entires also allows for some cleanups.

Ran through GHA, still need to do some more extensive testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326753: Lilliput: OMCache: Use AoS (Sub-task - P4)

Reviewers

• Roman Kennke (@rkennke - Reviewer) ⚠️ Review applies to 93fe1c28

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/lilliput.git pull/140/head:pull/140
$ git checkout pull/140

Update a local copy of the PR:
$ git checkout pull/140
$ git pull https://git.openjdk.org/lilliput.git pull/140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 140

View PR using the GUI difftool:
$ git pr show -t 140

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/lilliput/pull/140.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into pr/139 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 02: Full (b5a70518)
• 01: Full - Incremental (93fe1c28)
• 00: Full (93fe1c28)

[rkennke]

Looks good to me! Thank you!

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout omcache-aos
git fetch https://git.openjdk.org/lilliput.git omworld-jdk
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge omworld-jdk"
git push

[openjdk]

@xmas92 this pull request can not be integrated into omworld-jdk due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout omcache-aos
git fetch https://git.openjdk.org/lilliput.git omworld-jdk
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge omworld-jdk"
git push

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326753: Lilliput: OMCache: Use AoS

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the omworld-jdk branch:

• 9c09cda: 8326823: Lilliput: OMWorld: Separate NMT category

Please see this link for an up-to-date comparison between the source branch of this pull request and the omworld-jdk branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the omworld-jdk branch, type /integrate in a new comment.

[xmas92]

/integrate

[openjdk]

Going to push as commit 3aadead.
Since your change was applied there has been 1 commit pushed to the omworld-jdk branch:

• 9c09cda: 8326823: Lilliput: OMWorld: Separate NMT category

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit 3aadead.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.