Skip to content

8330631: Lilliput: Modify runtime/CompressedOops/CompressedClassPointers for tinycp #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rkennke
Copy link
Collaborator

@rkennke rkennke commented Apr 24, 2024

A patch that got lost in the Great Reset. Fixes test failure in runtime/CompressedOops/CompressedClassPointers.java. Originally done by @tstuefe .


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8330631: Lilliput: Modify runtime/CompressedOops/CompressedClassPointers for tinycp (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/lilliput.git pull/167/head:pull/167
$ git checkout pull/167

Update a local copy of the PR:
$ git checkout pull/167
$ git pull https://git.openjdk.org/lilliput.git pull/167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 167

View PR using the GUI difftool:
$ git pr show -t 167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/lilliput/pull/167.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2024

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330631: Lilliput: Modify runtime/CompressedOops/CompressedClassPointers for tinycp

Reviewed-by: stefank, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • a599676: Don't warn when UCOH is on by default
  • eddacbe: OMWorld: Fix enter_for is_value_based bug
  • a06a8ad: OMWorld: Cleanup BasicLock header
  • a512b0a: Fix arrays-equals intrinsic on AArch64
  • 1061cd4: OMWorld: Cleanup ObjectMonitor::_header
  • c4f8440: OMWorld: Add LightweightSynchronizer::quick_enter - fix incorrectly setup cache
  • 80abb98: Disable UseCompressedOops tests for 32-bits JVMs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 24, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2024

Webrevs

@rkennke rkennke requested a review from tstuefe April 24, 2024 14:38
Comment on lines 63 to 67
if (output.getOutput().contains(usesCompactObjectHeadersPat)) {
return true;
} else {
return false;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just:

Suggested change
if (output.getOutput().contains(usesCompactObjectHeadersPat)) {
return true;
} else {
return false;
}
return output.getOutput().contains(usesCompactObjectHeadersPat);

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2024
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@rkennke
Copy link
Collaborator Author

rkennke commented Apr 26, 2024

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

Going to push as commit 2bea858.
Since your change was applied there have been 7 commits pushed to the master branch:

  • a599676: Don't warn when UCOH is on by default
  • eddacbe: OMWorld: Fix enter_for is_value_based bug
  • a06a8ad: OMWorld: Cleanup BasicLock header
  • a512b0a: Fix arrays-equals intrinsic on AArch64
  • 1061cd4: OMWorld: Cleanup ObjectMonitor::_header
  • c4f8440: OMWorld: Add LightweightSynchronizer::quick_enter - fix incorrectly setup cache
  • 80abb98: Disable UseCompressedOops tests for 32-bits JVMs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 26, 2024
@openjdk openjdk bot closed this Apr 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2024
@openjdk
Copy link

openjdk bot commented Apr 26, 2024

@rkennke Pushed as commit 2bea858.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants