Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back out hashcode trimming #2

wants to merge 1 commit into from


Copy link

@rkennke rkennke commented May 10, 2021

I accidentally pushed a change in the mess around #1 that I did not mean to push now. I want to back out the trimming of i-hashcode and push it separately later.


  • Change must not contain extraneous whitespace
  • Change must be properly reviewed



Using git

Checkout this PR locally:
$ git fetch pull/2/head:pull/2
$ git checkout pull/2

Update a local copy of the PR:
$ git checkout pull/2
$ git pull pull/2/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2

View PR using the GUI difftool:
$ git pr show -t 2

Using diff file

Download this PR as a diff file:

Copy link

@shipilev shipilev left a comment

Looks fine.

Copy link

@bridgekeeper bridgekeeper bot commented May 10, 2021

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link

@openjdk openjdk bot commented May 10, 2021

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

Back out hashcode trimming

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels May 10, 2021
Copy link

@mlbridge mlbridge bot commented May 10, 2021


Copy link
Collaborator Author

@rkennke rkennke commented May 10, 2021


@openjdk openjdk bot closed this May 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 10, 2021
Copy link

@openjdk openjdk bot commented May 10, 2021

@rkennke Pushed as commit 3f1a758.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants