Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce +UseCompressedClassPointers #5

Closed
wants to merge 4 commits into from

Conversation

rkennke
Copy link
Collaborator

@rkennke rkennke commented May 17, 2021

This change force-enables +UseCompressedClassPointers. This is required for the next step where we want to store the compressed class pointers into object headers. The change also removes test configurations that explicitely disable CCP.
In the long run, we would remove the flag altogether, but not now.

Testing:

  • tier1
  • tier2
  • build x86 (32bit)

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/lilliput pull/5/head:pull/5
$ git checkout pull/5

Update a local copy of the PR:
$ git checkout pull/5
$ git pull https://git.openjdk.java.net/lilliput pull/5/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5

View PR using the GUI difftool:
$ git pr show -t 5

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/lilliput/pull/5.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 17, 2021

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 17, 2021

Webrevs

src/hotspot/share/runtime/arguments.cpp Outdated Show resolved Hide resolved
test/hotspot/jtreg/gc/metaspace/TestSizeTransitions.java Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Enforce +UseCompressedClassPointers

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 17, 2021
rkennke and others added 2 commits May 17, 2021
Co-authored-by: Aleksey Shipilëv <aleksey.shipilev@gmail.com>
Co-authored-by: Aleksey Shipilëv <aleksey.shipilev@gmail.com>
@rkennke
Copy link
Collaborator Author

@rkennke rkennke commented May 18, 2021

/integrate

@openjdk openjdk bot closed this May 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@rkennke Pushed as commit c6e863a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 18, 2021

Mailing list message from Thomas Stüfe on lilliput-dev:

I like this. This may be something for the mainline JDK too, independent
from Lilliput. Since CompressedClassPointers have been made independent
from CompressedOops, I don't see a reason to run
without CompressedClassPointers on 64bit. This would slash test effort and
remove unknowns (e.g. differences in heap usage when CCptrs are off).

Cheers, Thomas

On Mon, May 17, 2021 at 5:47 PM Roman Kennke <rkennke at openjdk.java.net>
wrote:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants