Skip to content

/ loom

Permalink
Browse files

8234935: JdwpListenTest.java and JdwpAttachTest.java getting bind fai… 

…lures on Windows 2016 hosts

Reviewed-by: cjplummer, sspitsyn
  • Loading branch information
Alex Menkov
Alex Menkov committed Feb 11, 2020
1 parent fbca3fa commit 84c24a49ad6ce9a3562acc1273c5f73d9975df33
Unified Split
Showing with 32 additions and 14 deletions.
  1. +0 −3 test/jdk/ProblemList.txt
  2. +15 −5 test/jdk/com/sun/jdi/JdwpAttachTest.java
  3. +17 −6 test/jdk/com/sun/jdi/JdwpListenTest.java
3 test/jdk/ProblemList.txt
View file
@@ -894,9 +894,6 @@ com/sun/jdi/RepStep.java 8043571 generic-

com/sun/jdi/NashornPopFrameTest.java 8225620 generic-all

com/sun/jdi/JdwpListenTest.java 8234935 windows-all
com/sun/jdi/JdwpAttachTest.java 8234935 windows-all

############################################################################

# jdk_time
20 test/jdk/com/sun/jdi/JdwpAttachTest.java
View file
@@ -25,6 +25,7 @@
import com.sun.jdi.VirtualMachine;
import com.sun.jdi.connect.Connector;
import com.sun.jdi.connect.ListeningConnector;
import jdk.test.lib.Platform;
import jdk.test.lib.apps.LingeredApp;

import java.net.Inet4Address;
@@ -33,7 +34,6 @@
import java.net.NetworkInterface;
import java.net.SocketException;
import java.net.UnknownHostException;
import java.util.Arrays;
import java.util.Enumeration;
import java.util.Iterator;
import java.util.LinkedList;
@@ -54,8 +54,6 @@
*/
public class JdwpAttachTest {

private static final boolean IsWindows = System.getProperty("os.name").toLowerCase().contains("windows");

// Set to true to perform testing of attach from wrong address (expected to fail).
// It's off by default as it caused significant test time increase\
// (tests <number_of_addresses> * <number_of_addresses> cases, each case fails by timeout).
@@ -115,7 +113,7 @@ private static void attachTest(String listenAddress, String connectAddress, bool
}
log(" Listening port: " + port);

log(" Attaching from " + connectAddress);
log(" Attaching to " + connectAddress);
try {
ExecutorService executor = Executors.newSingleThreadExecutor();
executor.submit((Callable<Exception>)() -> {
@@ -155,6 +153,12 @@ private static void addAddr(List<InetAddress> list, InetAddress addr) {
list.add(addr);
}

private static boolean isTeredo(Inet6Address addr) {
// Teredo prefix is 2001::/32 (i.e. first 4 bytes are 2001:0000)
byte[] bytes = addr.getAddress();
return bytes[0] == 0x20 && bytes[1] == 0x01 && bytes[2] == 0x00 && bytes[3] == 0x00;
}

private static List<InetAddress> getAddresses() {
List<InetAddress> result = new LinkedList<>();
try {
@@ -173,6 +177,12 @@ private static void addAddr(List<InetAddress> list, InetAddress addr) {
// On other platforms test both symbolic and numeric scopes.
if (addr instanceof Inet6Address) {
Inet6Address addr6 = (Inet6Address)addr;
// Teredo clients cause intermittent errors on listen ("bind failed")
// and attach ("no route to host").
// Teredo is supposed to be a temporary measure, but some test machines have it.
if (isTeredo(addr6)) {
continue;
}
NetworkInterface scopeIface = addr6.getScopedInterface();
if (scopeIface != null && scopeIface.getName() != null) {
// On some test machines VPN creates link local addresses
@@ -190,7 +200,7 @@ private static void addAddr(List<InetAddress> list, InetAddress addr) {
throw new RuntimeException("Unexpected", e);
}

if (IsWindows) {
if (Platform.isWindows()) {
// don't add addresses with symbolic scope
continue;
}
23 test/jdk/com/sun/jdi/JdwpListenTest.java
View file
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -26,6 +26,7 @@
import com.sun.jdi.connect.AttachingConnector;
import com.sun.jdi.connect.Connector;
import com.sun.jdi.connect.IllegalConnectorArgumentsException;
import jdk.test.lib.Platform;
import lib.jdb.Debuggee;

import java.io.IOException;
@@ -52,8 +53,6 @@
*/
public class JdwpListenTest {

private static final boolean IsWindows = System.getProperty("os.name").toLowerCase().contains("windows");

// Set to true to allow testing of attach from wrong address (expected to fail).
// It's off by default as it causes test time increase and test interference (see JDK-8231915).
private static boolean allowNegativeTesting = false;
@@ -89,7 +88,7 @@ public static void main(String[] args) throws Exception {

private static void listenTest(String listenAddress, String connectAddress, boolean expectedResult)
throws IOException {
log("\nTest: listen at " + listenAddress + ", attaching from " + connectAddress
log("\nTest: listen at " + listenAddress + ", attaching to " + connectAddress
+ ", expected: " + (expectedResult ? "SUCCESS" : "FAILURE"));
if (!expectedResult && !allowNegativeTesting) {
log("SKIPPED: negative testing is disabled");
@@ -99,7 +98,7 @@ private static void listenTest(String listenAddress, String connectAddress, bool
log("Starting listening debuggee at " + listenAddress);
try (Debuggee debuggee = Debuggee.launcher("HelloWorld").setAddress(listenAddress + ":0").launch()) {
log("Debuggee is listening on " + listenAddress + ":" + debuggee.getAddress());
log("Connecting from " + connectAddress + ", expected: " + (expectedResult ? "SUCCESS" : "FAILURE"));
log("Connecting to " + connectAddress + ", expected: " + (expectedResult ? "SUCCESS" : "FAILURE"));
try {
VirtualMachine vm = attach(connectAddress, debuggee.getAddress());
vm.dispose();
@@ -120,6 +119,12 @@ private static void addAddr(List<InetAddress> list, InetAddress addr) {
list.add(addr);
}

private static boolean isTeredo(Inet6Address addr) {
// Teredo prefix is 2001::/32 (i.e. first 4 bytes are 2001:0000)
byte[] bytes = addr.getAddress();
return bytes[0] == 0x20 && bytes[1] == 0x01 && bytes[2] == 0x00 && bytes[3] == 0x00;
}

private static List<InetAddress> getAddresses() {
List<InetAddress> result = new LinkedList<>();
try {
@@ -138,6 +143,12 @@ private static void addAddr(List<InetAddress> list, InetAddress addr) {
// On other platforms test both symbolic and numeric scopes.
if (addr instanceof Inet6Address) {
Inet6Address addr6 = (Inet6Address)addr;
// Teredo clients cause intermittent errors on listen ("bind failed")
// and attach ("no route to host").
// Teredo is supposed to be a temporary measure, but some test machines have it.
if (isTeredo(addr6)) {
continue;
}
NetworkInterface scopeIface = addr6.getScopedInterface();
if (scopeIface != null && scopeIface.getName() != null) {
// On some test machines VPN creates link local addresses
@@ -155,7 +166,7 @@ private static void addAddr(List<InetAddress> list, InetAddress addr) {
throw new RuntimeException("Unexpected", e);
}

if (IsWindows) {
if (Platform.isWindows()) {
// don't add addresses with symbolic scope
continue;
}

0 comments on commit 84c24a4

Please sign in to comment.