From a72d25fcc7bb8a590f7596abac00c5190931cf54 Mon Sep 17 00:00:00 2001 From: Kim Barrett Date: Fri, 30 Aug 2019 15:36:44 -0400 Subject: [PATCH] 8230372: Remove G1GCPhaseTimes::MergeLBProcessedBuffers Removed no longer needed phase time. Reviewed-by: sjohanss, tschatzl --- src/hotspot/share/gc/g1/g1CollectedHeap.cpp | 6 +----- src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp | 2 -- src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp | 2 -- test/hotspot/jtreg/gc/g1/TestGCLogMessages.java | 1 - 4 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/hotspot/share/gc/g1/g1CollectedHeap.cpp b/src/hotspot/share/gc/g1/g1CollectedHeap.cpp index 97f57b241c3..a9377157e33 100644 --- a/src/hotspot/share/gc/g1/g1CollectedHeap.cpp +++ b/src/hotspot/share/gc/g1/g1CollectedHeap.cpp @@ -1948,12 +1948,8 @@ void G1CollectedHeap::iterate_hcc_closure(G1CardTableEntryClosure* cl, uint work void G1CollectedHeap::iterate_dirty_card_closure(G1CardTableEntryClosure* cl, uint worker_i) { G1DirtyCardQueueSet& dcqs = G1BarrierSet::dirty_card_queue_set(); - size_t n_completed_buffers = 0; - while (dcqs.apply_closure_during_gc(cl, worker_i)) { - n_completed_buffers++; - } + while (dcqs.apply_closure_during_gc(cl, worker_i)) {} assert(dcqs.num_cards() == 0, "Completed buffers exist!"); - phase_times()->record_thread_work_item(G1GCPhaseTimes::MergeLB, worker_i, n_completed_buffers, G1GCPhaseTimes::MergeLBProcessedBuffers); } // Computes the sum of the storage used by the various regions. diff --git a/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp b/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp index 9f181e5c2ad..1e6750bd1f3 100644 --- a/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp +++ b/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp @@ -125,8 +125,6 @@ G1GCPhaseTimes::G1GCPhaseTimes(STWGCTimer* gc_timer, uint max_gc_threads) : _opt_scan_hr_used_memory = new WorkerDataArray(max_gc_threads, "Used Memory:"); _gc_par_phases[OptScanHR]->link_thread_work_items(_opt_scan_hr_used_memory, ScanHRUsedMemory); - _merge_lb_processed_buffers = new WorkerDataArray(max_gc_threads, "Processed Buffers:"); - _gc_par_phases[MergeLB]->link_thread_work_items(_merge_lb_processed_buffers, MergeLBProcessedBuffers); _merge_lb_dirty_cards = new WorkerDataArray(max_gc_threads, "Dirty Cards:"); _gc_par_phases[MergeLB]->link_thread_work_items(_merge_lb_dirty_cards, MergeLBDirtyCards); _merge_lb_skipped_cards = new WorkerDataArray(max_gc_threads, "Skipped Cards:"); diff --git a/src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp b/src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp index 0da5a47292d..dee53886c43 100644 --- a/src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp +++ b/src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp @@ -106,7 +106,6 @@ class G1GCPhaseTimes : public CHeapObj { }; enum GCMergeLBWorkItems { - MergeLBProcessedBuffers, MergeLBDirtyCards, MergeLBSkippedCards }; @@ -129,7 +128,6 @@ class G1GCPhaseTimes : public CHeapObj { WorkerDataArray* _merge_hcc_dirty_cards; WorkerDataArray* _merge_hcc_skipped_cards; - WorkerDataArray* _merge_lb_processed_buffers; WorkerDataArray* _merge_lb_dirty_cards; WorkerDataArray* _merge_lb_skipped_cards; diff --git a/test/hotspot/jtreg/gc/g1/TestGCLogMessages.java b/test/hotspot/jtreg/gc/g1/TestGCLogMessages.java index df1d601a73c..48caac0faa4 100644 --- a/test/hotspot/jtreg/gc/g1/TestGCLogMessages.java +++ b/test/hotspot/jtreg/gc/g1/TestGCLogMessages.java @@ -105,7 +105,6 @@ public boolean isAvailable() { new LogMessageWithLevel("Merged Coarse", Level.DEBUG), new LogMessageWithLevel("Hot Card Cache", Level.DEBUG), new LogMessageWithLevel("Log Buffers", Level.DEBUG), - new LogMessageWithLevel("Processed Buffers", Level.DEBUG), new LogMessageWithLevel("Dirty Cards", Level.DEBUG), new LogMessageWithLevel("Skipped Cards", Level.DEBUG), // Scan Heap Roots