Skip to content
Permalink
Browse files

8235791: [TESTBUG] Fix comment in TestElfDirectRead.java

Reviewed-by: dholmes, iklam
  • Loading branch information
jrziviani authored and Gustavo Romero committed Feb 13, 2020
1 parent 0870743 commit b72e31b39f8fc67a367ccc679586a7d8861f6f22
Showing with 4 additions and 4 deletions.
  1. +4 −4 test/hotspot/jtreg/runtime/ElfDecoder/TestElfDirectRead.java
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -36,10 +36,10 @@
*/

// This test intentionally disables caching of Elf sections during symbol lookup
// with WhiteBox.disableElfSectionCache(). On platforms which do not use file
// descriptors instead of plain function pointers this slows down the lookup just a
// with WhiteBox.disableElfSectionCache(). On platforms which do not use function
// descriptors but use instead plain function pointers this slows down the lookup just a
// little bit, because all the symbols from an Elf file are still read consecutively
// after one 'fseek()' call. But on platforms with file descriptors like ppc64
// after one 'fseek()' call. But on platforms with function descriptors like ppc64
// big-endian, we get two 'fseek()' calls for each symbol read from the Elf file
// because reading the file descriptor table is nested inside the loop which reads
// the symbols. This really trashes the I/O system and considerable slows down the

0 comments on commit b72e31b

Please sign in to comment.