Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial scoped locals implementation #1

wants to merge 1 commit into from


Copy link

@theRealAph theRealAph commented Feb 10, 2020

Here it is. Still no Structured Concurrency support, though.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
@bridgekeeper bridgekeeper bot added the oca label Feb 10, 2020
Copy link

@bridgekeeper bridgekeeper bot commented Feb 10, 2020

Hi theRealAph, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user theRealAph" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@bridgekeeper bridgekeeper bot removed the oca label Feb 10, 2020
Copy link
Collaborator Author

@theRealAph theRealAph commented Feb 12, 2020

This failed because there is no Bug ID, and no reviewer. But the other Loom commits don't have these. What do you want me to do?

Copy link

@openjdk openjdk bot commented Feb 14, 2020

@theRealAph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Initial scoped locals implementation
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 79 commits pushed to the fibers branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge fibers into your branch, and then specify the current head hash when integrating, like this: /integrate 07e388051bd3ea2b0dd1213adf905db8aa3539d8.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Feb 14, 2020
Copy link

@pron pron commented Feb 14, 2020

Changed jcheck configuration to allow this in 07e3880.

Copy link

@mlbridge mlbridge bot commented Feb 14, 2020


Copy link
Collaborator Author

@theRealAph theRealAph commented Feb 14, 2020


@openjdk openjdk bot closed this Feb 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 14, 2020
Copy link

@openjdk openjdk bot commented Feb 14, 2020

@theRealAph The following commits have been pushed to fibers since your change was applied:

  • 07e3880: Configure jcheck
  • 3371ef9: fiber -> virtual thread rename
  • afa1580: Remove MANAGED characteristic
  • 18ad724: Residual reference to fibers in comment
  • e934eb2: Clean-up merge witth JDK-8238231
  • 3039e61: Solaris PollerProvider not needed
  • 5ec05aa: JfrStackFrame adjustment
  • 320b3f8: Merge
  • 98f5d98: 8222793: Javadoc tool ignores "-locale" param and uses default locale for all messages and texts
  • c0f23a8: 8230047: Remove legacy java.lang.reflect.ProxyGenerator_v49
  • f133264: 8238225: Issues reported after replacing symlink at Contents/MacOS/libjli.dylib with binary
  • a7a82b0: 8235795: replace monitor list mux{Acquire,Release}(&gListLock) with spin locks
  • 8ff24c5: 8236035: refactor ObjectMonitor::set_owner() and _owner field setting
  • b9e3a4e: 8235931: add OM_CACHE_LINE_SIZE and use smaller size on SPARCv9 and X64
  • e7e182a: 8235699: ArrayIndexOutOfBoundsException in CalendarBuilder.toString
  • ccb4ab5: 8179317: [TESTBUG] rewrite runtime shell tests in java
  • 0372124: 8238388: libj2gss/NativeFunc.o "multiple definition" link errors with GCC10
  • ce28a96: 8238281: Raise minimum gcc version needed to 5.0
  • d6aeda7: 8238375: JFR Test TestJcmdStartFlushInterval is not run
  • c09e021: 8238515: Backout JDK-8236092 from jdk/jdk
  • 89e9ae9: Merge
  • 9ec5da0: 8238377: JDK 14 L10N resource file update - msgdrop 20
  • 7db8a17: 8237514: Spec Clarification - ByteBuffer::alignmentOffset Spec
  • 953fbd2: 8236743: JFR: assert(klass != __null) failed: invariant in ObjectSampleCheckpoint::add_to_leakp_set
  • 5495efd: 8236092: Remove EA from JDK 14 version string starting with Initial RC promotion
  • 06579fc: 8237804: sun/security/mscapi tests fail with "Key pair not generated, alias already exists"
  • 029f547: 8238467: Clean up annotations on overridden/implemented methods
  • 9d7777e: 8219475: javap man page needs to be updated
  • b75d375: 8238502: sunmscapi.dll causing EXCEPTION_ACCESS_VIOLATION
  • a88734e: 8238162: Shenandoah: Remove ShenandoahTaskTerminator wrapper
  • b069da3: 8238231: Custom DatagramSocketImpl's create method not called when with protected constructor
  • e104b4c: 8235954: [dmg] Default DMG background tiff of jpackage not retina ready
  • 135f209: 8238190: [JVMCI] Fix single implementor speculation for diamond shapes
  • f2b7509: 8237951: CTW: C2 compilation fails with "malformed control flow"
  • ef41763: 8237962: give better error output for invalid OCSP response intervals in CertPathValidator checks
  • edd2861: 8233220: Space::_par_seq_tasks is unused after CMS removal
  • 358c56b: 8238229: Remove TRACESPINNING debug code
  • 77ad678: 8238220: Rename OWSTTaskTerminator to TaskTerminator
  • 76675e9: 8215297: Remove ParallelTaskTerminator
  • 4b8a5f9: 8196875: Update run-test instructions for TEST_MODE
  • 0330504: 8238284: [macos] Zero VM build fails due to an obvious typo
  • 1cd5eac: 8238203: Return value of GetUserDefaultUILanguage() should be handled as LANGID
  • 319d697: 8238241: Clean up problem list for JFR tests
  • f6eaac4: 8238198: Avoid using @ tags in
  • b940e17: 8235332: fails with -XX:+StressGCM
  • 4122968: 8238259: new tests do not account for Windows file separators
  • 18d6d92: 8237953: vmTestbase/jit/tiered/ failure after JDK-8237798
  • ac6073f: 8237914: The test-make target does not fail on test failure
  • ee9483b: 8200363: Add javadoc command line setting to fail on warnings
  • 85f5e32: 8236949: javadoc -Xdoclint does not accumulate options correctly
  • b5bf0d6: 8235599: [TESTBUG] JFR streaming/ fails to cleanup files after test
  • bd7fd56: 8232636: JFR crashed and failed to create emergency dump file
  • cb636b2: 8219686: jdk/jfr/event/runtime/ recording file length is 0
  • 9cfd632: 8213918: DumpReason JFR event is not covered by test
  • 987ba9f: 8237521: Memory Access API fixes for 32-bit
  • 44444bb: 8238189: Cleanups to AES crypto micros
  • 9dcbd81: 8237080: fatal error: VM thread could block on lock that may be held by a JavaThread during safepoint: SharedDecoder_lock
  • 4aa5cf5: 8237882: ZGC: Remove ZUtils::round_{up,down}_power_of_2() declarations
  • 8391196: 8237884: ZGC: Use clamp() instead of MIN2(MAX2())
  • 0f06a9a: 8237825: ZGC: Replace -XX:ZPath with -XX:AllocateHeapAt
  • 24691f2: 8237758: ZGC: Move get_mempolicy() syscall wrapper to ZSyscall
  • 91d58b8: 8237649: ZGC: Improved NUMA support when using small pages
  • 06456a9: 8238224: test\jdk\jdk\jfr\event\io\ should be removed
  • af5c725: 8237879: make 4.3 breaks build
  • dfb3120: 8221331: test/jdk/jdk/jfr/event/io/ needs to re-worked to avoid recursive initialization issues
  • cd01fa3: 8223699: cleanup perfMemory_aix.cpp O_NOFOLLOW coding on aix
  • 0b9ff0c: 8202142: jfr/event/io/TestInstrumentation is unstable
  • d65f966: 8229971: Arm32: implementation for Thread-local handshakes
  • c4b708b: 8237857: LogDecorations::uptimenanos is implemented incorrectly
  • 0b45b7a: Merge
  • 06bf842: Added tag jdk-14+34 for changeset a96bc204e3b3
  • cdd3cc4: 8238168: Remove Copyright from WinLauncher.template
  • 5d8d4ce: Added tag jdk-15+8 for changeset c7d4f2849dbf
  • c484e1c: 8237787: rewrite vmTestbase/vm/compiler/CodeCacheInfo* from shell to java
  • 2880106: 8237574: Make TestNative work without -nativepath
  • 8aff9fc: 8215890: Simplify jdk/jfr/api/recording/event/
  • 70fdf1e: 8237364: Add early validation to the jdk.jfr.Recording constructor
  • 5b5a535: 7175279: Don't use x87 FPU on x86-64
  • a2bbf93: 8222001: JFR event for heap dumps written

Your commit was automatically rebased without conflicts.

Pushed as commit adb3efe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.