Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured concurrency support for scoped locals #2

Conversation

@theRealAph
Copy link
Collaborator

@theRealAph theRealAph commented Feb 18, 2020


Progress

  • Change must not contain extraneous whitespace

Download

$ git fetch https://git.openjdk.java.net/loom pull/2/head:pull/2
$ git checkout pull/2

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 18, 2020

👋 Welcome back aph! A progress list of the required criteria for merging this PR into fibers will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2020

@theRealAph This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added ready rfr labels Feb 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2020

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2020

Mailing list message from Brian Goetz on loom-dev:

I presume that the public `setParent()` method is there as a quick hack
for purposes of prototyping, and not intended as an API proposal?

On 2/18/2020 1:07 PM, Andrew Haley wrote:

Structured concurrency support for scoped locals

-------------

Commits:
- 7429ba0: Structured concurrency support for scoped locals

Changes: https://git.openjdk.java.net/loom/pull/2/files
Webrev: https://webrevs.openjdk.java.net/loom/2/webrev.00
Stats: 72 lines in 5 files changed: 51 ins; 11 del; 10 mod
Patch: https://git.openjdk.java.net/loom/pull/2.diff
Fetch: git fetch https://git.openjdk.java.net/loom pull/2/head:pull/2

PR: https://git.openjdk.java.net/loom/pull/2

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 19, 2020

Mailing list message from Alan Bateman on loom-dev:

On 18/02/2020 22:46, Brian Goetz wrote:

I presume that the public `setParent()` method is there as a quick
hack for purposes of prototyping, and not intended as an API proposal?
It's not public and I assume it just to get the PoC working. Threads
usually inherit at Thread creation time (rather than start time which
can be problematic sometimes when an unstarted Thread is passed around).
In any case, my reading of this PoC is that its for one scenario/usage
only as it doesn't prevent the scoped binding in the parent from being
closed (or mutated?) and I assume it doesn't work with thread pools
where the setup/tear-down is around the task rather than the thread.
This area will likely require many rounds of exploration and prototyping.

-Alan

@openjdk openjdk bot added outdated and removed ready rfr labels Feb 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2020

@theRealAph this pull request can no longer be integrated into fibers due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout scoped-locals-structured-concurency
git fetch https://git.openjdk.java.net/loom fibers
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge fibers"
git push
@openjdk openjdk bot added the merge-conflict label Mar 23, 2020
@AlanBateman AlanBateman closed this Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.