Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope locals next #34

Closed
wants to merge 20 commits into from
Closed

Conversation

theRealAph
Copy link
Collaborator

@theRealAph theRealAph commented Mar 12, 2021

Partial rewrite of Scope Locals support. Faster, main class renamed, lots of good stuff.


Progress

  • Change must not contain extraneous whitespace

Download

$ git fetch https://git.openjdk.java.net/loom pull/34/head:pull/34
$ git checkout pull/34

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2021

👋 Welcome back aph! A progress list of the required criteria for merging this PR into fibers will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@theRealAph
Copy link
Collaborator Author

theRealAph commented Mar 15, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Mar 15, 2021

@theRealAph Your integration request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

@theRealAph
Copy link
Collaborator Author

theRealAph commented Mar 15, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Mar 15, 2021

@theRealAph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Scope locals next

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 127 new commits pushed to the fibers branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the fibers branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Mar 15, 2021
@theRealAph
Copy link
Collaborator Author

theRealAph commented Mar 15, 2021

/integrate

@openjdk openjdk bot closed this Mar 15, 2021
@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 15, 2021
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Mar 15, 2021
@openjdk
Copy link

openjdk bot commented Mar 15, 2021

@theRealAph Since your change was applied there have been 127 commits pushed to the fibers branch:

Your commit was automatically rebased without conflicts.

Pushed as commit beefaaa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Mar 15, 2021

@theRealAph The command integrate can only be used in open pull requests.

@mlbridge
Copy link

mlbridge bot commented Mar 15, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
1 participant