Skip to content
Permalink
Browse files

8234541: C1 emits an empty message when it inlines successfully

Use "inline" as the message when successfull

Reviewed-by: thartmann, mdoerr
  • Loading branch information
navyxliu authored and Paul Hohensee committed Nov 30, 2019
1 parent f3e9059 commit 4e64af81a2ea66313d03b720004667bc7975f6e4
Showing with 5 additions and 10 deletions.
  1. +4 −9 src/hotspot/share/c1/c1_GraphBuilder.cpp
  2. +1 −1 src/hotspot/share/c1/c1_GraphBuilder.hpp
@@ -3793,7 +3793,7 @@ bool GraphBuilder::try_inline_full(ciMethod* callee, bool holder_known, bool ign
INLINE_BAILOUT("total inlining greater than DesiredMethodLimit");
}
// printing
print_inlining(callee);
print_inlining(callee, "inline", /*success*/ true);
}

// NOTE: Bailouts from this point on, which occur at the
@@ -4315,16 +4315,11 @@ static void post_inlining_event(EventCompilerInlining* event,
void GraphBuilder::print_inlining(ciMethod* callee, const char* msg, bool success) {
CompileLog* log = compilation()->log();
if (log != NULL) {
assert(msg != NULL, "inlining msg should not be null!");
if (success) {
if (msg != NULL)
log->inline_success(msg);
else
log->inline_success("receiver is statically known");
log->inline_success(msg);
} else {
if (msg != NULL)
log->inline_fail(msg);
else
log->inline_fail("reason unknown");
log->inline_fail(msg);
}
}
EventCompilerInlining event;
@@ -381,7 +381,7 @@ class GraphBuilder {
void append_unsafe_get_and_set_obj(ciMethod* callee, bool is_add);
void append_char_access(ciMethod* callee, bool is_store);

void print_inlining(ciMethod* callee, const char* msg = NULL, bool success = true);
void print_inlining(ciMethod* callee, const char* msg, bool success = true);

void profile_call(ciMethod* callee, Value recv, ciKlass* predicted_holder, Values* obj_args, bool inlined);
void profile_return_type(Value ret, ciMethod* callee, ciMethod* m = NULL, int bci = -1);

0 comments on commit 4e64af8

Please sign in to comment.
You can’t perform that action at this time.