From 680fceb9ba192a98f48cc672df04b5bf6b95d8b0 Mon Sep 17 00:00:00 2001 From: Ivan Gerasimov Date: Fri, 27 Sep 2019 17:50:09 -0700 Subject: [PATCH] 8230415: Avoid redundant permission checking in FilePermissionCollection and SocketPermissionCollection Reviewed-by: mullan --- src/java.base/share/classes/java/io/FilePermission.java | 2 +- src/java.base/share/classes/java/net/SocketPermission.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/java.base/share/classes/java/io/FilePermission.java b/src/java.base/share/classes/java/io/FilePermission.java index e2227131808..614bfe1b855 100644 --- a/src/java.base/share/classes/java/io/FilePermission.java +++ b/src/java.base/share/classes/java/io/FilePermission.java @@ -1196,7 +1196,7 @@ public boolean implies(Permission permission) { if ((effective & desired) == desired) { return true; } - needed = (desired ^ effective); + needed = (desired & ~effective); } } return false; diff --git a/src/java.base/share/classes/java/net/SocketPermission.java b/src/java.base/share/classes/java/net/SocketPermission.java index 3abf17604e0..2452fbbbfe4 100644 --- a/src/java.base/share/classes/java/net/SocketPermission.java +++ b/src/java.base/share/classes/java/net/SocketPermission.java @@ -1433,7 +1433,7 @@ public boolean implies(Permission permission) if ((effective & desired) == desired) { return true; } - needed = (desired ^ effective); + needed = (desired & ~effective); } } return false;