From 6d8acd2696f41918d4233ddffe46e6c205f9dbc3 Mon Sep 17 00:00:00 2001 From: Mandy Chung Date: Tue, 10 Nov 2020 17:51:52 +0000 Subject: [PATCH] 8256066: Tests use deprecated TestNG API that is no longer available in new versions Reviewed-by: jjg --- test/jdk/java/lang/invoke/ConstantIdentityMHTest.java | 6 ++---- test/jdk/java/lang/invoke/DropArgumentsTest.java | 9 +++------ test/jdk/java/lang/invoke/VarArgsTest.java | 3 +-- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/test/jdk/java/lang/invoke/ConstantIdentityMHTest.java b/test/jdk/java/lang/invoke/ConstantIdentityMHTest.java index 34c97a955ae..c0db09bb42a 100644 --- a/test/jdk/java/lang/invoke/ConstantIdentityMHTest.java +++ b/test/jdk/java/lang/invoke/ConstantIdentityMHTest.java @@ -59,8 +59,7 @@ public void testZero(Class expectedtype, String expected) throws Throwable { assertEquals(MethodHandles.zero(expectedtype).type().toString(), expected); } - @Test - @ExpectedExceptions(NullPointerException.class) + @Test(expectedExceptions={ NullPointerException.class }) public void testZeroNPE() { MethodHandle mh = MethodHandles.zero(null); } @@ -73,8 +72,7 @@ void testEmpty() throws Throwable { assertEquals((String)mhEmpty.invoke("x","y"), null); } - @Test - @ExpectedExceptions(NullPointerException.class) + @Test(expectedExceptions = { NullPointerException.class }) void testEmptyNPE() { MethodHandle lenEmptyMH = MethodHandles.empty(null); } diff --git a/test/jdk/java/lang/invoke/DropArgumentsTest.java b/test/jdk/java/lang/invoke/DropArgumentsTest.java index be65b39b276..fd36d07767c 100644 --- a/test/jdk/java/lang/invoke/DropArgumentsTest.java +++ b/test/jdk/java/lang/invoke/DropArgumentsTest.java @@ -65,8 +65,7 @@ private Object[][] dropArgumentsToMatchNPEData() }; } - @Test(dataProvider = "dropArgumentsToMatchNPEData") - @ExpectedExceptions(NullPointerException.class) + @Test(dataProvider = "dropArgumentsToMatchNPEData", expectedExceptions = { NullPointerException.class }) public void dropArgumentsToMatchNPE(MethodHandle target, int pos, List> valueType, int skip) { MethodHandles.dropArgumentsToMatch(target, pos, valueType , skip); } @@ -85,14 +84,12 @@ private Object[][] dropArgumentsToMatchIAEData() }; } - @Test(dataProvider = "dropArgumentsToMatchIAEData") - @ExpectedExceptions(IllegalArgumentException.class) + @Test(dataProvider = "dropArgumentsToMatchIAEData", expectedExceptions = { IllegalArgumentException.class }) public void dropArgumentsToMatchIAE(MethodHandle target, int pos, List> valueType, int skip) { MethodHandles.dropArgumentsToMatch(target, pos, valueType , skip); } - @Test - @ExpectedExceptions(IllegalArgumentException.class) + @Test(expectedExceptions = { IllegalArgumentException.class }) public void dropArgumentsToMatchTestWithVoid() throws Throwable { MethodHandle cat = lookup().findVirtual(String.class, "concat", MethodType.methodType(String.class, String.class)); diff --git a/test/jdk/java/lang/invoke/VarArgsTest.java b/test/jdk/java/lang/invoke/VarArgsTest.java index 2fef2cd90b0..23baee3be88 100644 --- a/test/jdk/java/lang/invoke/VarArgsTest.java +++ b/test/jdk/java/lang/invoke/VarArgsTest.java @@ -69,8 +69,7 @@ public void testWithVarargs2() throws Throwable { assertEquals("[two, too]", asListWithVarargs.invoke("two", "too").toString()); } - @Test - @ExpectedExceptions(IllegalArgumentException.class) + @Test(expectedExceptions = { IllegalArgumentException.class }) public void testWithVarargsIAE() throws Throwable { MethodHandle lenMH = publicLookup() .findVirtual(String.class, "length", methodType(int.class));