Skip to content
Permalink
Browse files
8266295: Remove unused _concurrent_iteration_safe_limit
Reviewed-by: tschatzl, sjohanss
  • Loading branch information
albertnetymk committed May 3, 2021
1 parent b42d496 commit ac760c7f9fca2cad3f2ae8a3da80d3f3a91163fb
@@ -650,9 +650,6 @@ void DefNewGeneration::collect(bool full,
}
// We should have processed and cleared all the preserved marks.
_preserved_marks_set.reclaim();
// set new iteration safe limit for the survivor spaces
from()->set_concurrent_iteration_safe_limit(from()->top());
to()->set_concurrent_iteration_safe_limit(to()->top());

heap->trace_heap_after_gc(&gc_tracer);

@@ -264,8 +264,7 @@ void Space::clear(bool mangle_space) {
}
}

ContiguousSpace::ContiguousSpace(): CompactibleSpace(), _top(NULL),
_concurrent_iteration_safe_limit(NULL) {
ContiguousSpace::ContiguousSpace(): CompactibleSpace(), _top(NULL) {
_mangler = new GenSpaceMangler(this);
}

@@ -278,7 +277,6 @@ void ContiguousSpace::initialize(MemRegion mr,
bool mangle_space)
{
CompactibleSpace::initialize(mr, clear_space, mangle_space);
set_concurrent_iteration_safe_limit(top());
}

void ContiguousSpace::clear(bool mangle_space) {
@@ -499,7 +499,6 @@ class ContiguousSpace: public CompactibleSpace {

protected:
HeapWord* _top;
HeapWord* _concurrent_iteration_safe_limit;
// A helper for mangling the unused area of the space in debug builds.
GenSpaceMangler* _mangler;

@@ -564,24 +563,10 @@ class ContiguousSpace: public CompactibleSpace {
void oop_iterate(OopIterateClosure* cl);
void object_iterate(ObjectClosure* blk);

HeapWord* concurrent_iteration_safe_limit() {
assert(_concurrent_iteration_safe_limit <= top(),
"_concurrent_iteration_safe_limit update missed");
return _concurrent_iteration_safe_limit;
}
// changes the safe limit, all objects from bottom() to the new
// limit should be properly initialized
void set_concurrent_iteration_safe_limit(HeapWord* new_limit) {
assert(new_limit <= top(), "uninitialized objects in the safe range");
_concurrent_iteration_safe_limit = new_limit;
}

// Compaction support
virtual void reset_after_compaction() {
assert(compaction_top() >= bottom() && compaction_top() <= end(), "should point inside space");
set_top(compaction_top());
// set new iteration safe limit
set_concurrent_iteration_safe_limit(compaction_top());
}

// Override.
@@ -130,7 +130,6 @@
nonstatic_field(CompactibleSpace, _end_of_live, HeapWord*) \
\
nonstatic_field(ContiguousSpace, _top, HeapWord*) \
nonstatic_field(ContiguousSpace, _concurrent_iteration_safe_limit, HeapWord*) \
nonstatic_field(ContiguousSpace, _saved_mark_word, HeapWord*) \
\
nonstatic_field(Generation, _reserved, MemRegion) \

0 comments on commit ac760c7

Please sign in to comment.