Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244412: jextract should generate static utils class for primitive typedefs #144

Closed

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented May 5, 2020

generating static utils classes for (subset of) primitive typedef trees.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8244412: jextract should generate static utils class for primitive typedefs

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/144/head:pull/144
$ git checkout pull/144

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 5, 2020

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request.

Loading

@openjdk openjdk bot added the rfr label May 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 5, 2020

Webrevs

Loading

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Very nice and clean!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2020

@sundararajana This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244412: jextract should generate static utils class for primitive typedefs

Reviewed-by: mcimadamore
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the foreign-jextract branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate f25bc5d09e2458e906285370928bfc8b29c1f1b0.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 5, 2020
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 5, 2020

/integrate

Loading

@openjdk openjdk bot closed this May 5, 2020
@openjdk openjdk bot added integrated and removed ready labels May 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2020

@sundararajana
Pushed as commit 663dfca.

Loading

@openjdk openjdk bot removed the rfr label May 5, 2020
@sundararajana sundararajana deleted the JDK-8244412 branch May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants