Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244512: jextract throws NPE for a nested struct declaration #146

Closed

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented May 6, 2020

saving/restoring 'old' struct builder in visitScoped.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8244512: jextract throws NPE for a nested struct declaration

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/146/head:pull/146
$ git checkout pull/146

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 6, 2020

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 6, 2020
Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good

@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2020

@sundararajana This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244512: jextract throws NPE for a nested struct declaration

Reviewed-by: mcimadamore
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the foreign-jextract branch:

  • 9ad9268: 8244425: primitive typedef names differing only in case mapped to nested classes with names differing only in case

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge foreign-jextract into your branch, and then specify the current head hash when integrating, like this: /integrate 9ad926833acb5af07491b411fa25325b029d6bcc.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 6, 2020

Webrevs

@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 6, 2020

/integrate

@openjdk openjdk bot closed this May 6, 2020
@openjdk openjdk bot added integrated and removed ready labels May 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2020

@sundararajana The following commits have been pushed to foreign-jextract since your change was applied:

  • 9ad9268: 8244425: primitive typedef names differing only in case mapped to nested classes with names differing only in case

Your commit was automatically rebased without conflicts.

Pushed as commit 6f69981.

@openjdk openjdk bot removed the rfr label May 6, 2020
@sundararajana sundararajana deleted the JDK-8244512 branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants