Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround JDK-8239083 #151

Closed
wants to merge 1 commit into from
Closed

Conversation

@JornVernee
Copy link
Member

@JornVernee JornVernee commented May 6, 2020

Hi,

This patch is a workaround for https://bugs.openjdk.java.net/browse/JDK-8239083 which causes problems when running on a debug build.

Thanks,
Jorn


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Athijegannathan Sundararajan (sundar - Committer)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/151/head:pull/151
$ git checkout pull/151

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 6, 2020

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-abi will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 6, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2020

@JornVernee This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

Workaround JDK-8239083

Reviewed-by: sundar
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the foreign-abi branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 50e5acd7699da49948bcf12fead5953e87356e79.

➡️ To integrate this PR with the above commit message to the foreign-abi branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 6, 2020
@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented May 6, 2020

/integrate

@openjdk openjdk bot closed this May 6, 2020
@openjdk openjdk bot added integrated and removed ready labels May 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2020

@JornVernee
Pushed as commit 023cac3.

@openjdk openjdk bot removed the rfr label May 6, 2020
@JornVernee JornVernee deleted the JornVernee:C1_workaround branch May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants