Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MemoryAddress::copy (more review feedback) #172

Closed

Conversation

@mcimadamore
Copy link
Collaborator

@mcimadamore mcimadamore commented May 15, 2020

This simple patch addresses some of the review feedback from Paul (sorry for having integrated too soon!).

Cheers


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Paul Sandoz (psandoz - Committer)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/172/head:pull/172
$ git checkout pull/172

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 15, 2020

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-memaccess will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 15, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 15, 2020

@mcimadamore This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

Move MemoryAddress::copy (more review feedback)

Reviewed-by: psandoz
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-memaccess branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 3487383884a0c2af1fa58186e771b54598c92805.

➡️ To integrate this PR with the above commit message to the foreign-memaccess branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 15, 2020
@mcimadamore
Copy link
Collaborator Author

@mcimadamore mcimadamore commented May 15, 2020

/integrate

@openjdk openjdk bot closed this May 15, 2020
@openjdk openjdk bot added integrated and removed ready labels May 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 15, 2020

@mcimadamore
Pushed as commit 0bc9c6b.

@openjdk openjdk bot removed the rfr label May 15, 2020
@mcimadamore mcimadamore deleted the mcimadamore:copyMove+followup branch Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants