Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245767: jextract crashes with typedef on a opaque struct or union #181

Closed

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented May 26, 2020

Class for struct/union typedef is generated only if definition was seen earlier.
Or else it is saved and revisited after all declarations are seen.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8245767: jextract crashes with typedef on a opaque struct or union

Reviewers

  • Jorn Vernee (jvernee - Committer)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/181/head:pull/181
$ git checkout pull/181

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 26, 2020

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 26, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 26, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2020

@sundararajana This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245767: jextract crashes with typedef on a opaque struct or union

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-jextract branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 65bde071e767a4be34412498d2efe46b3a6f0696.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 26, 2020
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 26, 2020

/integrate

@openjdk openjdk bot closed this May 26, 2020
@openjdk openjdk bot added integrated and removed ready labels May 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2020

@sundararajana
Pushed as commit 3d14704.

@openjdk openjdk bot removed the rfr label May 26, 2020
@sundararajana sundararajana deleted the JDK-8245767 branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants