Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding libgit2 sample. #182

Closed

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented May 27, 2020

GitClone.java is a simple Java program to clone a repo from Github.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/182/head:pull/182
$ git checkout pull/182

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 27, 2020

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 27, 2020
Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Minor issue in text

java -Dforeign.restricted=permit --add-modules jdk.incubator.foreign \
-Djava.library.path=${LIBGIT2_HOME}/build/ \
GitClone.java $*
Copy link
Collaborator

@mcimadamore mcimadamore May 27, 2020

GitClone vs GitMain in the source code - mismatch?

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 27, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2020

@sundararajana This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

adding libgit2 sample.

Reviewed-by: mcimadamore
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-jextract branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 3d14704c67261df21460ac545bc6fb181bbcb967.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 27, 2020
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 27, 2020

/integrate

@openjdk openjdk bot closed this May 27, 2020
@openjdk openjdk bot added integrated and removed ready labels May 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2020

@sundararajana
Pushed as commit 0e27dc9.

@openjdk openjdk bot removed the rfr label May 27, 2020
@sundararajana sundararajana deleted the libgit2-sample branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants