Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8246040: java/foreign/TestAddressHandle fails on big endian platforms #186

Closed
wants to merge 1 commit into from

Conversation

@mcimadamore
Copy link
Collaborator

@mcimadamore mcimadamore commented May 28, 2020

This is a fix for TestAddressHandle to be Big Endianness friendly. The test was relying on the fact that writing the constant 42L was setting the lowest order bit on the segment. I have now updated the test to change that (and tested by tweaking the data provider to use big endian layouts).


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8246040: java/foreign/TestAddressHandle fails on big endian platforms

Reviewers

  • Athijegannathan Sundararajan (sundar - Committer)
  • Jorn Vernee (jvernee - Committer)
  • Chris Hegarty (chegar - no project role)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/186/head:pull/186
$ git checkout pull/186

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 28, 2020

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-memaccess will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 28, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 28, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2020

@mcimadamore This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8246040: java/foreign/TestAddressHandle fails on big endian platforms

Reviewed-by: sundar, jvernee, chegar
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-memaccess branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate dedc7d8f35ce5b567d39aa76e25938bdbf2160db.

➡️ To integrate this PR with the above commit message to the foreign-memaccess branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 28, 2020
@mcimadamore
Copy link
Collaborator Author

@mcimadamore mcimadamore commented May 28, 2020

/integrate

@openjdk openjdk bot closed this May 28, 2020
@openjdk openjdk bot added integrated and removed ready labels May 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2020

@mcimadamore
Pushed as commit 3535293.

@openjdk openjdk bot removed the rfr label May 28, 2020
@mcimadamore mcimadamore deleted the mcimadamore:addressBE branch Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.