Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8246053: Add a mask for default access modesAdd a default access mode flag #188

Closed
wants to merge 3 commits into from

Conversation

@mcimadamore
Copy link
Collaborator

@mcimadamore mcimadamore commented May 28, 2020

This is a simple change which adds a 'default' access mask. This was pointed out during CSR review, and I realized that many tests were also using it.
It can also be handy when creating more restricted masks (e.g. start with default and remove one or two access modes).

I've updated tests, documentation and some of the impl to use the new mask accordingly.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8246053: Add a mask for default access modes ⚠️ Title mismatch between PR and JBS.

Reviewers

  • Athijegannathan Sundararajan (sundar - Committer) ⚠️ Review applies to 0d19173
  • Chris Hegarty (chegar - no project role) ⚠️ Review applies to 7aec883

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/188/head:pull/188
$ git checkout pull/188

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 28, 2020

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-memaccess will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 28, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 28, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2020

@mcimadamore This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8246053: Add a mask for default access modesAdd a default access mode flag

Reviewed-by: sundar, chegar
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-memaccess branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 648b843fe0a15ed4e143808696a6f76c08af3e7d.

➡️ To integrate this PR with the above commit message to the foreign-memaccess branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 28, 2020
Copy link
Member

@ChrisHegarty ChrisHegarty left a comment

This looks good. I've ended up doing similar in tests too, so I think that this is a good addition.

I might quibble about the name, whyDEFAULT_ACCESS and not something like ALL_MODES, or ALL_ACCESS, or some such?

@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2020

@mcimadamore this pull request can not be integrated into foreign-memaccess due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout allaccess
git fetch https://git.openjdk.java.net/panama-foreign foreign-memaccess
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge foreign-memaccess"
git push
@openjdk openjdk bot added merge-conflict and removed ready labels May 28, 2020
@mcimadamore mcimadamore force-pushed the mcimadamore:allaccess branch from 7aec883 to 6db6ad2 May 28, 2020
@openjdk openjdk bot added ready and removed merge-conflict labels May 28, 2020
@mcimadamore
Copy link
Collaborator Author

@mcimadamore mcimadamore commented May 28, 2020

/integrate

@openjdk openjdk bot closed this May 28, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2020

@mcimadamore
Pushed as commit fee6f89.

Copy link
Member

@sundararajana sundararajana left a comment

Looks good.

@mcimadamore mcimadamore deleted the mcimadamore:allaccess branch Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants