Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure should fail if libclang path is not specified #190

Closed

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented May 29, 2020

configure fails after the message rather than continuging after warning


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Chris Hegarty (chegar - no project role)
  • Maurizio Cimadamore (mcimadamore - Committer)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/190/head:pull/190
$ git checkout pull/190

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 29, 2020

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 29, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 29, 2020

Webrevs

Copy link
Member

@ChrisHegarty ChrisHegarty left a comment

Looks good to me.

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good to me - thanks. This has bit me (and probably others) several times.

@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2020

@sundararajana This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

configure should fail if libclang path is not specified

Reviewed-by: chegar, mcimadamore
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 41 commits pushed to the foreign-jextract branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge foreign-jextract into your branch, and then specify the current head hash when integrating, like this: /integrate a630e7bff44e9375b2b055268bb5f5ea1bcb93e9.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 29, 2020
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 29, 2020

/integrate

@openjdk openjdk bot closed this May 29, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2020

@sundararajana The following commits have been pushed to foreign-jextract since your change was applied:

  • a630e7b: Automatic merge of foreign-abi into foreign-jextract
  • 5604738: Automatic merge of foreign-memaccess into foreign-abi
  • 0215250: Automatic merge of master into foreign-memaccess
  • ccb9dfe: Automatic merge of jdk:master into master
  • 4708c6d: 8243507: DatagramSocket constructors don’t always specify what happens when passed invalid parameters
  • 7228978: 8242504: Enhance the system clock to nanosecond precision
  • 60ac615: 8240259: Disable -Wshift-negative-value warnings
  • e29685f: 8246109: Remove unneeded undef CS
  • e0d0388: 8244668: Remove SA's javascript support
  • de34e25: 8244622: Remove SA's memory/FreeChunk.java. It's no longer used
  • 7045a46: 8244993: Revert changes to OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings() that allow version strings
  • 6df2a95: Added tag jdk-15+25 for changeset 90b266a84c06
  • f3c463b: 8244703: "platform encoding not initialized" exceptions with debugger, JNI
  • 23ce03d: 8245505: Prelink j.l.ref.Reference when loading AOT library
  • b189d0b: 8245478: Implementation: JEP 379: Shenandoah: A Low-Pause-Time Garbage Collector (Production)
  • 3459f9b: 8245942: Shenandoah: x86_32 builds fail after JDK-8245594
  • f702f4d: 8246023: Obsolete LIRFillDelaySlot
  • a9477eb: 8245718: Epsilon: improve configuration logging
  • 919f10c: 8245864: Obsolete BranchOnRegister
  • 6f4f6a2: 8245955: Shenandoah: Remove LRB/is_redundant optimization
  • 57388f8: 8244504: C2: refactor counted loop code in preparation for long counted loop
  • 456fe23: 8230827: javac gives inappropriate warning about potentially ambiguous methods
  • 7671f27: 8245786: Scope is wrong for ClassTree representing record
  • dfc7905: 8246027: Minimal fastdebug build broken after JDK-8245801
  • 8ea971e: 8246034: Remove java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js and java.base/share/classes/jdk/internal/jrtfs/jrtls.js
  • 686ca5a: 8243936: NonWriteable system properties are actually writeable
  • 60ce159: Added tag jdk-15+25 for changeset 588330449887
  • 4aea733: 8245062: HtmlStyle: group and document members for nav, header, summary, details
  • e6855f2: 8245264: Test runtime/cds/appcds/SignedJar.java fails
  • 7e85b2c: 8245969: Simplify String concat constant folding
  • 69f7f95: 8245959: Extend String concat testing to account for folded constants
  • 4ad8992: 8245850: Obsolete UseLWPSynchronization
  • 17a2989: 8206925: Support the certificate_authorities extension
  • 6f5e8a2: 8237908: [TESTBUG] [macos] Add support to jtreg helpers to unpack pkg packages
  • 93d89d3: 8242786: [macos] tools/jpackage/share/IconTest.java fails: ABORT trying to dequeue work
  • 4af3a1e: 8245202: Convert existing jpackage tests to newer form
  • afbdb49: 8245827: Shenandoah: Cleanup Shenandoah code root iterators and root scanner
  • 954db33: 8241312: missing code coverage for records
  • 37c3b0b: 8245814: Shenandoah: reconsider format specifiers for stats
  • b8d49f8: 8245825: Shenandoah: Remove diagnostic flag ShenandoahConcurrentScanCodeRoots
  • db1ef58: 8245823: Shenandoah: inline/optimize ShenandoahEvacOOMScope

Your commit was automatically rebased without conflicts.

Pushed as commit b32e205.

@sundararajana sundararajana deleted the sundararajana:libclang-config branch May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants