Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252704: Absolute library paths are not properly quoted #302

Closed

Conversation

@JornVernee
Copy link
Member

@JornVernee JornVernee commented Sep 2, 2020

Hi,

This PR fixes a minor issue where backslashes (\) in absolute library paths result in un-compilable sources on Windows.

Thanks,
Jorn


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8252704: Absolute library paths are not properly quoted

Reviewers

  • Athijegannathan Sundararajan (sundar - Committer)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/302/head:pull/302
$ git checkout pull/302

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 2, 2020

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Sep 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 2, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 2, 2020

@JornVernee This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252704: Absolute library paths are not properly quoted

Reviewed-by: sundar
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-jextract branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate a22b3791e73f87389c3d67ad47dad24ec6ac7f1b.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 2, 2020
@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Sep 2, 2020

/integrate

@openjdk openjdk bot closed this Sep 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 2, 2020

@JornVernee The following commits have been pushed to foreign-jextract since your change was applied:

  • 1dc9149: 8252705: private static final constants lead to compilation errors

Your commit was automatically rebased without conflicts.

Pushed as commit eb0768a.

@JornVernee JornVernee deleted the QuoteLibPaths branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants