Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252756: jextract does not handle VLAs/Incomplete Arrays/Flexible arrays #305

Closed
wants to merge 1 commit into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Sep 3, 2020

Hi,

This PR removes the variable length array workarounds that were needed pre-LLVM 9, and adds a test that verifies that the correct layout is generated for a struct containing a VLA.

Thanks,
Jorn


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8252756: jextract does not handle VLAs/Incomplete Arrays/Flexible arrays

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/305/head:pull/305
$ git checkout pull/305

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 3, 2020

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Sep 3, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 3, 2020

Webrevs

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good

@openjdk
Copy link

@openjdk openjdk bot commented Sep 3, 2020

@JornVernee This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252756: jextract does not handle VLAs/Incomplete Arrays/Flexible arrays

Reviewed-by: mcimadamore
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-jextract branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate eb0768aae2928e0c869220e96e3fb2ad41c294ad.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 3, 2020
@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Sep 3, 2020

/integrate

@openjdk openjdk bot closed this Sep 3, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 3, 2020

@JornVernee
Pushed as commit 2407b9d.

@JornVernee JornVernee deleted the VLA branch Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants