Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252700: jextract ignores typedef to undefined structs #307

Closed

Conversation

sundararajana
Copy link
Member

@sundararajana sundararajana commented Sep 4, 2020

A class with annotated allocatePointer methods is generated


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8252700: jextract ignores typedef to undefined structs

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/307/head:pull/307
$ git checkout pull/307

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 4, 2020

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Sep 4, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 4, 2020

Webrevs

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good.
I note a mild inconsistencies in the sense that, in most emitXYZ the annotation is passed from outside, while in emitTypeDef the annotation is calculated internally.

I believe this way is totally the right way to go and that, currently, the various source builders are too "stringy" so, perhaps in the future, we can clean up some of the code by always genertating metadata in the source builders rather than output factory, and pass more types/declarations around.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 4, 2020

@sundararajana This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252700: jextract ignores typedef to undefined structs

Reviewed-by: mcimadamore
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-jextract branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 2407b9da6ff47cf1fda0b9a12b7bff6c87758fed.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 4, 2020
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented Sep 4, 2020

/integrate

@openjdk openjdk bot closed this Sep 4, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 4, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 4, 2020

@sundararajana
Pushed as commit 8eee4ed.

@sundararajana sundararajana deleted the JDK-8252700 branch Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants