Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252838: Panama foreign-abi branch fails to build #309

Closed
wants to merge 1 commit into from

Conversation

sundararajana
Copy link
Member

@sundararajana sundararajana commented Sep 7, 2020

sync'ing with the changes done via bug fix 8244090


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8252838: Panama foreign-abi branch fails to build

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/309/head:pull/309
$ git checkout pull/309

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 7, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@sundararajana This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252838: Panama foreign-abi branch fails to build

Reviewed-by: jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-abi branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate f6e1fcd5cb343e264dc6ceaca19a3589b556f1de.

➡️ To integrate this PR with the above commit message to the foreign-abi branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 7, 2020
@sundararajana
Copy link
Member Author

sundararajana commented Sep 7, 2020

/integrate

@openjdk openjdk bot closed this Sep 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@sundararajana Pushed as commit 769c080.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sundararajana
Copy link
Member Author

sundararajana commented Sep 7, 2020

/integrate

@sundararajana sundararajana deleted the JDK-8252838 branch Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants