Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252899: jextract can't handle multiple extern declarations that have the same name, but a different type name #313

Closed
wants to merge 1 commit into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Sep 8, 2020

Hi,

This PR let's jextract handle cases like the one described in the bug:

typedef int MyInt;

extern const int x;
extern const MyInt x; 

Where the same global variable is re-declared, but slightly differently.

The current code is de-duping globals using the declaration. Changing this to de-duping by name allows use to also handle these cases.

Thanks,
Jorn


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8252899: jextract can't handle multiple extern declarations that have the same name, but a different type name

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/313/head:pull/313
$ git checkout pull/313

…efinition of globals with the same type but under a different name (typedef).
@JornVernee JornVernee requested a review from sundararajana Sep 8, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 8, 2020

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@JornVernee This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252899: jextract can't handle multiple extern declarations that have the same name, but a different type name

Reviewed-by: sundar
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the foreign-jextract branch:

  • 33cba7a: adding tensorflow sample
  • b5bcdc2: Automatic merge of foreign-abi into foreign-jextract
  • 5f63553: 8252872: NativeScope should take Addressable instead of MemoryAddress

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge foreign-jextract into your branch, and then specify the current head hash when integrating, like this: /integrate 33cba7a01f086569181308d8b67f9ff040230d78.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 8, 2020
@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Sep 8, 2020

/integrate

@openjdk openjdk bot closed this Sep 8, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2020

@JornVernee Since your change was applied there have been 3 commits pushed to the foreign-jextract branch:

  • 33cba7a: adding tensorflow sample
  • b5bcdc2: Automatic merge of foreign-abi into foreign-jextract
  • 5f63553: 8252872: NativeScope should take Addressable instead of MemoryAddress

Your commit was automatically rebased without conflicts.

Pushed as commit 6f39187.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 8, 2020

Webrevs

@JornVernee JornVernee deleted the Redefs branch Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants