Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253102: jextract should emit address to segment utility method on struct classes #324

Closed

Conversation

sundararajana
Copy link
Member

@sundararajana sundararajana commented Sep 14, 2020

added utility method to struct classes.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8253102: jextract should emit address to segment utility method on struct classes

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/324/head:pull/324
$ git checkout pull/324

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good!

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2020

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented Sep 14, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@sundararajana This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253102: jextract should emit address to segment utility method on struct classes

Reviewed-by: mcimadamore, jvernee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the foreign-jextract branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 619473341d19c2e4963b54123a3dc88dd1e0d815.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 14, 2020
@openjdk openjdk bot closed this Sep 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@sundararajana Pushed as commit e474374.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2020

Webrevs

@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented Sep 14, 2020

/integrate

@sundararajana sundararajana deleted the JDK-8253102 branch Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants