8254983: jextract fails to hande layout paths nested structs/union

[mcimadamore]

This patch fixes an issue with jextract code generation. More specifically, when multiple structs with same name are found in an header (this is possible if the structs are at different level of nesting e.g. Foo.Bar vs. Foo.Baz.Bar), jextract erroneously uses the struct simple name to qualifiy the various fields associated with the struct (such as the layout field). Because of this, there are cases where, when generating a var handle for a struct field, we erroneously pick up the layout corresponding to a different struct, which then causes an error at runtime.

The fix is to always disambiguate struct names when in nested context, so that Foo.Bar and Foo.Baz.Bar lead to different constant names.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	❌ (5/5 failed)	❌ (2/2 failed)	❌ (2/2 failed)

Failed test tasks

• Linux x64 (build debug)
• Linux x64 (build hotspot minimal)
• Linux x64 (build hotspot no-pch)
• Linux x64 (build hotspot zero)
• Linux x64 (build release)
• Windows x64 (build debug)
• Windows x64 (build release)
• macOS x64 (build debug)
• macOS x64 (build release)

Issue

• JDK-8254983: jextract fails to hande layout paths nested structs/union

Reviewers

• Jorn Vernee (@JornVernee - Committer)
• Athijegannathan Sundararajan (@sundararajana - Committer)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/384/head:pull/384
$ git checkout pull/384

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (4577e30)
• 00: Full (0059cc4)

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254983: jextract fails to hande layout paths nested structs/union

Reviewed-by: jvernee, sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the foreign-jextract branch:

• 4f8777e: Merge foreign-abi
• c32f108: Merge foreign-memaccess
• 63df0ec: Merge master
• 68f0d9b: Automatic merge of jdk:master into master
• 1742c44: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
• 34583eb: 8254161: Prevent instantiation of EnumSet subclasses through deserialization
• 3d23bd8: 8254814: [Vector API] Fix an AVX512 crash after JDK-8223347
• 7c0d417: 8251535: Partial peeling at unsigned test adds incorrect loop exit check
• 5145bed: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows
• bdda205: 8254369: Node::disconnect_inputs may skip precedences
• ... and 100 more: https://git.openjdk.java.net/panama-foreign/compare/d8c0d0d74b87520bfa1d1c8aa18519e2d038f724...foreign-jextract

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

[sundararajana]

I reviewed the changes. Also I tested all samples (source and binary mode) on Mac. All jextract and run fine.

[mcimadamore]

/integrate

[openjdk]

@mcimadamore Since your change was applied there have been 110 commits pushed to the foreign-jextract branch:

• 4f8777e: Merge foreign-abi
• c32f108: Merge foreign-memaccess
• 63df0ec: Merge master
• 68f0d9b: Automatic merge of jdk:master into master
• 1742c44: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
• 34583eb: 8254161: Prevent instantiation of EnumSet subclasses through deserialization
• 3d23bd8: 8254814: [Vector API] Fix an AVX512 crash after JDK-8223347
• 7c0d417: 8251535: Partial peeling at unsigned test adds incorrect loop exit check
• 5145bed: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows
• bdda205: 8254369: Node::disconnect_inputs may skip precedences
• ... and 100 more: https://git.openjdk.java.net/panama-foreign/compare/d8c0d0d74b87520bfa1d1c8aa18519e2d038f724...foreign-jextract

Your commit was automatically rebased without conflicts.

Pushed as commit d841b84.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.