Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262117: jextract crashes with javac compilation error "class u is already defined" #458

Closed

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented Feb 23, 2021

enclosing names are checked for clash now


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8262117: jextract crashes with javac compilation error "class u is already defined"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/458/head:pull/458
$ git checkout pull/458

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 23, 2021

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Feb 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 23, 2021

Webrevs

Loading

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good, added a minor comment

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 23, 2021

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262117: jextract crashes with javac compilation error "class u is already defined"

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-jextract branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Feb 23, 2021
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented Feb 23, 2021

/integrate

Loading

@openjdk openjdk bot closed this Feb 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 23, 2021

@sundararajana Pushed as commit 6c47c8d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@sundararajana sundararajana deleted the JDK-8262117 branch Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants