Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260976: investigate ways to filter jextract output #493

Closed

Conversation

mcimadamore
Copy link
Collaborator

@mcimadamore mcimadamore commented Apr 8, 2021

This simple patch fixes a remaining use of -Dforeign.restriced=permit in the filter test.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8260976: investigate ways to filter jextract output ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/493/head:pull/493
$ git checkout pull/493

Update a local copy of the PR:
$ git checkout pull/493
$ git pull https://git.openjdk.java.net/panama-foreign pull/493/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 493

View PR using the GUI difftool:
$ git pr show -t 493

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/493.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 8, 2021

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260976: investigate ways to filter jextract output

Reviewed-by: sundar, jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the foreign-jextract branch:

  • f2f3ace: Automatic merge of foreign-memaccess+abi into foreign-jextract
  • e9b8a6a: 8264763: Add support for extended map modes in mapped segments

Please see this link for an up-to-date comparison between the source branch of this pull request and the foreign-jextract branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Apr 8, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2021

Webrevs

@mcimadamore
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this Apr 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Apr 8, 2021
@openjdk
Copy link

openjdk bot commented Apr 8, 2021

@mcimadamore Since your change was applied there have been 2 commits pushed to the foreign-jextract branch:

  • f2f3ace: Automatic merge of foreign-memaccess+abi into foreign-jextract
  • e9b8a6a: 8264763: Add support for extended map modes in mapped segments

Your commit was automatically rebased without conflicts.

Pushed as commit 34b5b68.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants