Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265760: Memory segments/addresses should have an isNative predicate #514

Conversation

@mcimadamore
Copy link
Collaborator

@mcimadamore mcimadamore commented Apr 22, 2021

This patch adds an isNative predicate to both MemorySegment and MemoryAddress. Note that, for segments, isMapped implies isNative.

It also moves all the methods from MappedMemorySegments back into MemorySegment (these methods will still throw if invoked on a segment that is not a mapped segment).

Some javadoc tweaking occurred here - MemorySegment now has a new section fully dedicated to mapped segments (note that now mapped segments are presented as a special class of native segments).

Also, in MemoryAddress, the concept of "native memory address" is introduced to talk about off-heap addresses, which simplifies some of the javadoc.

This way, the resulting API is tighter, and using mapped segments is slightly more direct.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8265760: Memory segments/addresses should have an isNative predicate

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/514/head:pull/514
$ git checkout pull/514

Update a local copy of the PR:
$ git checkout pull/514
$ git pull https://git.openjdk.java.net/panama-foreign pull/514/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 514

View PR using the GUI difftool:
$ git pr show -t 514

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/514.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 22, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2021

Webrevs

* is small enough, due to the size limitation inherent to the ByteBuffer API.
* <p>
* Clients requiring sophisticated, low-level control over mapped memory segments, should consider writing
* custom mapped memory segment factories; using JNI, e.g. on Linux, it is possible to call {@code mmap}
Copy link
Member

@PaulSandoz PaulSandoz Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace the reference to JNI with the linker API?

Copy link
Collaborator Author

@mcimadamore mcimadamore Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - that's actually what I wanted to do in the first place - dunno how I ended up with JNI :-)

@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265760: Memory segments/addresses should have an isNative predicate

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 236 new commits pushed to the foreign-memaccess+abi branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 23, 2021
@mcimadamore
Copy link
Collaborator Author

@mcimadamore mcimadamore commented Apr 23, 2021

/integrate

@openjdk openjdk bot closed this Apr 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 23, 2021

@mcimadamore Since your change was applied there have been 237 commits pushed to the foreign-memaccess+abi branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 122c7b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants