Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266916: Simplify logic for creating libSysLookup #533

Conversation

@mcimadamore
Copy link
Collaborator

@mcimadamore mcimadamore commented May 11, 2021

On Linux/Mac, the makefile for generating libSysLookup contains some unnecessary flags (given that the sources contain no code).
Moreover, it is not necessary to have a list of all headers - we can just include a single header (to make the build/toolchain happy) and rely on linker to pull in dependencies.
On Linux, also add libdl as a dependency (the VM also depends on that, so we can depend on that).


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8266916: Simplify logic for creating libSysLookup

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/533/head:pull/533
$ git checkout pull/533

Update a local copy of the PR:
$ git checkout pull/533
$ git pull https://git.openjdk.java.net/panama-foreign pull/533/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 533

View PR using the GUI difftool:
$ git pr show -t 533

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/533.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 11, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 11, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2021

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266916: Simplify logic for creating libSysLookup

Reviewed-by: sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-memaccess+abi branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 11, 2021
@mcimadamore
Copy link
Collaborator Author

@mcimadamore mcimadamore commented May 11, 2021

/integrate

@openjdk openjdk bot closed this May 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2021

@mcimadamore Pushed as commit 669eb87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants