Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266911: On Windows the system lookup should load ucrtbase if possible #534

Closed

Conversation

@JornVernee
Copy link
Member

@JornVernee JornVernee commented May 11, 2021

The current system lookup on Windows is always backed by msvcrt.dll, but since Windows 10 the core runtime is located in ucrtbase.dll (though the legacy msvcrt.dll is still available).

We should try to load ucrtbase first if it's available, as it's more up to date.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8266911: On Windows the system lookup should load ucrtbase if possible

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/534/head:pull/534
$ git checkout pull/534

Update a local copy of the PR:
$ git checkout pull/534
$ git pull https://git.openjdk.java.net/panama-foreign pull/534/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 534

View PR using the GUI difftool:
$ git pr show -t 534

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/534.diff

@JornVernee JornVernee changed the base branch from foreign-jextract to foreign-memaccess+abi May 11, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 11, 2021

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 11, 2021

Webrevs

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Very good

@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2021

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266911: On Windows the system lookup should load ucrtbase if possible

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-memaccess+abi branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 11, 2021
@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented May 11, 2021

/integrate

@openjdk openjdk bot closed this May 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2021

@JornVernee Pushed as commit f787414.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants