Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267305: regenerate clang jextract binding #538

Closed

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented May 18, 2021

clang.symbols file to list the symbols used.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/538/head:pull/538
$ git checkout pull/538

Update a local copy of the PR:
$ git checkout pull/538
$ git pull https://git.openjdk.java.net/panama-foreign pull/538/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 538

View PR using the GUI difftool:
$ git pr show -t 538

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/538.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 18, 2021

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 18, 2021

Webrevs

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks really good and much more compact than what we had before!
I left some minor code comments on code not autogenerated.

Copy link
Member

@JornVernee JornVernee left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267305: regenerate clang jextract binding

Reviewed-by: mcimadamore, jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the foreign-jextract branch:

  • 6442b5f: Automatic merge of foreign-memaccess+abi into foreign-jextract
  • 18f0e47: 8267240: Bounded arena allocator doesn't work if bounded size > BLOCK_SIZE

Please see this link for an up-to-date comparison between the source branch of this pull request and the foreign-jextract branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 18, 2021
Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good

@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 18, 2021

/integrate

@openjdk openjdk bot closed this May 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@sundararajana Since your change was applied there have been 2 commits pushed to the foreign-jextract branch:

  • 6442b5f: Automatic merge of foreign-memaccess+abi into foreign-jextract
  • 18f0e47: 8267240: Bounded arena allocator doesn't work if bounded size > BLOCK_SIZE

Your commit was automatically rebased without conflicts.

Pushed as commit 601ce85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sundararajana sundararajana deleted the JDK-8267305 branch May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants