Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267504: jextract should report unsupported language and exit rather than generating partial nonworking code #539

Closed

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented May 20, 2021

Piggybacking to remove unused code. Avoid hardcoding enum values - using generated code instead.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8267504: jextract should report unsupported language and exit rather than generating partial nonworking code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/539/head:pull/539
$ git checkout pull/539

Update a local copy of the PR:
$ git checkout pull/539
$ git pull https://git.openjdk.java.net/panama-foreign pull/539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 539

View PR using the GUI difftool:
$ git pr show -t 539

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/539.diff

…than generating partial nonworking code

Piggybacking to remove usused code, avoid hard coding of enum values (using generated code instead)
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 20, 2021

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 20, 2021

Webrevs

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good - I'm not sure I get the need for the full.symbol list

@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 21, 2021

I wanted to save full symbols file if in case if we wanted to bring few more symbols from libclang in future.

…rate "Invalid" language type (for example "packed")
Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good

@openjdk
Copy link

@openjdk openjdk bot commented May 21, 2021

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267504: jextract should report unsupported language and exit rather than generating partial nonworking code

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-jextract branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 21, 2021
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 21, 2021

/integrate

@openjdk openjdk bot closed this May 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 21, 2021

@sundararajana Pushed as commit 12615a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sundararajana sundararajana deleted the JDK-8267504 branch May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants