Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267536: Many tests fail on Windows because of recent jextract changes to CursorKind #541

Closed

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented May 21, 2021

added all cursor attribute kinds from Index.h


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8267536: Many tests fail on Windows because of recent jextract changes to CursorKind

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/541/head:pull/541
$ git checkout pull/541

Update a local copy of the PR:
$ git checkout pull/541
$ git pull https://git.openjdk.java.net/panama-foreign pull/541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 541

View PR using the GUI difftool:
$ git pr show -t 541

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/541.diff

Copy link
Member

@JornVernee JornVernee left a comment

LGTM

@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 21, 2021

Thanks @JornVernee for running tests and samples on Windows

@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 21, 2021

/integrate

@sundararajana sundararajana deleted the JDK-8267536 branch May 21, 2021
@sundararajana sundararajana restored the JDK-8267536 branch May 21, 2021
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 21, 2021

/integrate

@sundararajana sundararajana reopened this May 21, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 21, 2021

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 21, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented May 21, 2021

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267536: Many tests fail on Windows because of recent jextract changes to CursorKind

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-jextract branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented May 21, 2021

/integrate

@openjdk openjdk bot closed this May 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 21, 2021

@sundararajana Pushed as commit 94da9da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 21, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 21, 2021

@sundararajana The command integrate can only be used in open pull requests.

@openjdk
Copy link

@openjdk openjdk bot commented May 21, 2021

@sundararajana The command integrate can only be used in open pull requests.

@openjdk
Copy link

@openjdk openjdk bot commented May 21, 2021

@sundararajana The command integrate can only be used in open pull requests.

@sundararajana sundararajana deleted the JDK-8267536 branch Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants