Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268319: VersionCheck test fails for jextract on Windows #552

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Jun 7, 2021

The test tools/launcher/VersionCheck fails for jextract on Windows, because the filtering logic to filter out warnings in the output checks that the executable file name is "jextract", while on Windows it's "jextract.exe". So, the warnings are never filtered


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8268319: VersionCheck test fails for jextract on Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/552/head:pull/552
$ git checkout pull/552

Update a local copy of the PR:
$ git checkout pull/552
$ git pull https://git.openjdk.java.net/panama-foreign pull/552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 552

View PR using the GUI difftool:
$ git pr show -t 552

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/552.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 7, 2021

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link
Member

@sundararajana sundararajana left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Jun 7, 2021

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268319: VersionCheck test fails for jextract on Windows

Reviewed-by: sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-jextract branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jun 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 7, 2021

Webrevs

@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Jun 7, 2021

/integrate

@openjdk openjdk bot closed this Jun 7, 2021
@openjdk openjdk bot added integrated and removed ready labels Jun 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 7, 2021

@JornVernee Pushed as commit 2a24393.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Jun 7, 2021
@JornVernee JornVernee deleted the Fix_VersionCheck_Windows branch Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants