Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273382: jextract should generete alias layout for pointer typedefs #575

Closed

Conversation

sundararajana
Copy link
Member

@sundararajana sundararajana commented Sep 8, 2021

Generating C_POINTER layout variables for pointer typedefs in the header


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8273382: jextract should generete alias layout for pointer typedefs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/575/head:pull/575
$ git checkout pull/575

Update a local copy of the PR:
$ git checkout pull/575
$ git pull https://git.openjdk.java.net/panama-foreign pull/575/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 575

View PR using the GUI difftool:
$ git pr show -t 575

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/575.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 8, 2021

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 8, 2021

Webrevs

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Very nice!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273382: jextract should generete alias layout for pointer typedefs

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-jextract branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 8, 2021
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented Sep 8, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

Going to push as commit 2142785.

@openjdk openjdk bot closed this Sep 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@sundararajana Pushed as commit 2142785.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sundararajana sundararajana deleted the JDK-8273382 branch Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants