Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274219: Add back generic factory to create value layouts #579

Closed

Conversation

@mcimadamore
Copy link
Collaborator

@mcimadamore mcimadamore commented Sep 23, 2021

This patch adds back a factory to create value layouts in a generic way. While we cannot make the API 100% type safe, some dynamic usages can greatly benefit from this. The Binding class provides a good example (greatly simplified here). Also, the logic for reconstructing layouts (see describeConstable) becomes a lot more regular.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8274219: Add back generic factory to create value layouts

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/579/head:pull/579
$ git checkout pull/579

Update a local copy of the PR:
$ git checkout pull/579
$ git pull https://git.openjdk.java.net/panama-foreign pull/579/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 579

View PR using the GUI difftool:
$ git pr show -t 579

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/579.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 23, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 23, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274219: Add back generic factory to create value layouts

Reviewed-by: jvernee, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-memaccess+abi branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 23, 2021
…MemoryLayout.java

Co-authored-by: Paul Sandoz <paul.d.sandoz@googlemail.com>
@mcimadamore
Copy link
Collaborator Author

@mcimadamore mcimadamore commented Sep 23, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

Going to push as commit 79b304b.

Loading

@openjdk openjdk bot closed this Sep 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2021

@mcimadamore Pushed as commit 79b304b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants