8274592: Performance regression in upcalls

[mcimadamore]

Following the recent API refresh, I noticed that the QSort benchmark was broken (as it passed MemoryAddress where Addressable was expected). Upon fixing the benchmark, I realized that performance of upcalls dropped significantly (~3x).

After some investigation, I realized that we were using the default scope factory (which uses a cleaner!) inside some classes in the linker implementation.

The solution is to use the explicit factory which disables the cleaner, so as to avoid overhead.

There were similar issues in microbenchmarks; while using the default factory is fine for e.g. fields, using it for benchmark code is not great, as that skews the benchmark (because of the cleaner). So I replaced all usages of the default factories in the benchmark methods, except in places where we explicitly wanted to use them.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• JDK-8274592: Performance regression in upcalls

Reviewers

• Jorn Vernee (@JornVernee - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/588/head:pull/588
$ git checkout pull/588

Update a local copy of the PR:
$ git checkout pull/588
$ git pull https://git.openjdk.java.net/panama-foreign pull/588/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 588

View PR using the GUI difftool:
$ git pr show -t 588

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/588.diff

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (b37bf207)

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274592: Performance regression in upcalls

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-memaccess+abi branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

[mcimadamore]

/integrate

[openjdk]

Going to push as commit 9cd966f.

[openjdk]

@mcimadamore Pushed as commit 9cd966f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.