Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275061: Exceptions thrown from non-void upcalls are not handled #597

Closed

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Oct 11, 2021

Hi,

Exceptions thrown from non-void upcalls are currently not handled, meaning we crash the VM instead without a stack trace (CATCH macro).

Only the void case is currently handled for specialized upcalls. This PR adds the missing call to handle any uncaught exceptions for non-void upcalls as well.

Jorn


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8275061: Exceptions thrown from non-void upcalls are not handled

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/597/head:pull/597
$ git checkout pull/597

Update a local copy of the PR:
$ git checkout pull/597
$ git pull https://git.openjdk.java.net/panama-foreign pull/597/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 597

View PR using the GUI difftool:
$ git pr show -t 597

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/597.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 11, 2021

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 11, 2021

Webrevs

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good. I've always assumed, wrongly, that printing the exception name was the best we could do :-)

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275061: Exceptions thrown from non-void upcalls are not handled

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-memaccess+abi branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 11, 2021
@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Oct 11, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

Going to push as commit 9608462.

@openjdk openjdk bot closed this Oct 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@JornVernee Pushed as commit 9608462.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JornVernee JornVernee deleted the Upcall_Exceptions_2 branch Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants